This is an archive of the discontinued LLVM Phabricator instance.

test infra: move test event-related handling into its own package
ClosedPublic

Authored by tfiala on Apr 19 2016, 3:03 PM.

Details

Reviewers
zturner
labath
Summary

This change moves all the test event handling and its related ResultsFormatter classes out of the packages/Python/lldbsuite/test dir into a packages/Python/lldbsuite/test_event package. Formatters are moved into a sub-package under that.

I am limiting the scope of this change to just the motion and a few minor issues caught by a static Python checker (e.g. removing unused import statements).

This is a pre-step for adding package-level tests to the test event system. I also intend to simplify test event results formatter selection after I make sure this doesn't break anybody.

Diff Detail

Event Timeline

tfiala updated this revision to Diff 54268.Apr 19 2016, 3:03 PM
tfiala retitled this revision from to test infra: move test event-related handling into its own package.
tfiala updated this object.
tfiala added reviewers: labath, zturner.
tfiala added a subscriber: lldb-commits.
labath accepted this revision.Apr 20 2016, 3:01 AM
labath edited edge metadata.

Makes sense.

packages/Python/lldbsuite/test_event/formatter/curses.py
2

Is this actually supposed to be executable?

This revision is now accepted and ready to land.Apr 20 2016, 3:01 AM
packages/Python/lldbsuite/test_event/formatter/curses.py
2

No, there is no need for it to be executable. That can come out.

Good catch. I'll clean that up before submission.

tfiala updated this revision to Diff 54381.Apr 20 2016, 9:28 AM
tfiala edited edge metadata.

Removed unnecessary shebang line on curses.py, and normalizes LLVM license headers across all test_event package files.

tfiala closed this revision.Apr 20 2016, 9:35 AM

Closed with commit r266885.

@zturner, we can post-commit adjust if you see any improvements. I want to get moving on writing the package-level tests for it.

packages/Python/lldbsuite/test/test_result.py