Page MenuHomePhabricator

Tweaks to get_started.html, especially for Windows developers
ClosedPublic

Authored by amccarth on Apr 19 2016, 2:08 PM.

Details

Summary
  1. Add note about preserving FL line endings on Windows. Failure to do so causes about 30 tests to fail.
  2. Check out is two words when used as a verb.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth updated this revision to Diff 54259.Apr 19 2016, 2:08 PM
amccarth retitled this revision from to Tweaks to get_started.html, especially for Windows developers.
amccarth updated this object.
amccarth added a reviewer: yaron.keren.
amccarth added a subscriber: llvm-commits.
yaron.keren edited edge metadata.Apr 20 2016, 9:01 AM

AFAIK the eol type is decided by svn based the svn:eol-style property, so as long the files were checked in correctly and you do not override it specifically while svn checkout, it just works.
Did you encounter problems with eol ?

Like many folks, I use git-svn, and I had git's core.autocrlf config set to
true, which worked fine when working on LLDB (which I've been doing for
about a year). The first time I tried to run Clang tests, however, I got
about 30 failures because of the CR+LFs.

My opinion is that the tests are too fragile if they can't handle platform
native line separators, but until we fix that, the note seems useful.

Aid.

yaron.keren accepted this revision.Apr 20 2016, 9:41 AM
yaron.keren edited edge metadata.

Ah, OK, I am using regular svn and thus did not counter this problem.
Could you detail this exactly, the problem happens when using git-svn with core.autocrlf config=true but not with svn?
LGTM with this addition.

This revision is now accepted and ready to land.Apr 20 2016, 9:41 AM
This revision was automatically updated to reflect the committed changes.