This is an archive of the discontinued LLVM Phabricator instance.

Differential D19207

[gold-plugin] Improve coverage with tests
ClosedPublic

Authored by davide on Apr 17 2016, 6:46 PM.

Details

Reviewers
• rafael
Commits
rGb4d0521c925e: [gold] Test that we handle invalid directory correctly.
rL281109: [gold] Test that we handle invalid directory correctly.

Diff Detail

Event Timeline

davide updated this revision to Diff 54021.Apr 17 2016, 6:46 PM
davide retitled this revision from to [gold-plugin] Improve coverage with tests.
davide updated this object.
davide added a reviewer: • rafael.
davide added a subscriber: llvm-commits.
• rafael edited edge metadata.Apr 19 2016, 8:01 AM
• rafael added a subscriber: • rafael.

@@ -0,0 +1,5 @@
+; RUN: rm -rf %t.notexists

You probably don't need the rm -rf since the file is not created.

+; RUN: not %gold -plugin %llvmshlibdir/LLVMgold.so -shared \
+; RUN: %t.notexists 2>&1 | FileCheck %s -check-prefix=ENOENT
+
+; ENOENT: No such file or directory

  • /dev/null

+++ test/tools/gold/invalid-dir.ll
@@ -0,0 +1,7 @@
+; RUN: rm -rf %t.output

rmdir maybe

+; RUN: mkdir %t.output
+; RUN: llvm-as %s -o %t.o
+; RUN: not %gold -plugin %llvmshlibdir/LLVMgold.so -shared \
+; RUN: %t.o -o %t.output 2>&1 | FileCheck %s -check-prefix=OUTDIR
+
+; OUTDIR: fatal error:

Can you add a bit more of the error message?

Closed by commit rL281109: [gold] Test that we handle invalid directory correctly. (authored by davide). · Explain WhySep 9 2016, 3:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tools/
gold/
7 lines
2 lines
5 lines

Diff 54021

test/tools/gold/invalid-dir.ll

  • This file was added.
; RUN: rm -rf %t.output
; RUN: mkdir %t.output
; RUN: llvm-as %s -o %t.o
; RUN: not %gold -plugin %llvmshlibdir/LLVMgold.so -shared \
; RUN: %t.o -o %t.output 2>&1 | FileCheck %s -check-prefix=OUTDIR
; OUTDIR: fatal error:

test/tools/gold/lit.local.cfg

  • This file was added.
if (not 'ld_plugin' in config.available_features):
config.unsupported = True

test/tools/gold/nofile.ll

  • This file was added.
; RUN: rm -rf %t.notexists
; RUN: not %gold -plugin %llvmshlibdir/LLVMgold.so -shared \
; RUN: %t.notexists 2>&1 | FileCheck %s -check-prefix=ENOENT
; ENOENT: No such file or directory