This is an archive of the discontinued LLVM Phabricator instance.

[sanitizers] [SystemZ] Introduce sanitizer_linux_s390.cc.
ClosedPublic

Authored by koriakin on Apr 15 2016, 12:52 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

koriakin retitled this revision from to [sanitizers] [SystemZ] Introduce sanitizer_linux_s390.cc..
koriakin updated this object.
koriakin added a reviewer: kcc.
koriakin set the repository for this revision to rL LLVM.
koriakin added a project: Restricted Project.
koriakin added a subscriber: llvm-commits.
kcc edited edge metadata.Apr 15 2016, 2:28 PM

Thanks, I like this better. Added 2 comments.

lib/sanitizer_common/sanitizer_linux.cc
127

add // not s390

lib/sanitizer_common/sanitizer_linux_s390.cc
17

I would prefer you if can define SANITIZER_S390 (or some such), similar to SANITIZER_MIPS
and then use it everywhere instead of defined(s390)

koriakin edited edge metadata.
kcc accepted this revision.Apr 15 2016, 3:15 PM
kcc edited edge metadata.

LGTM, thanks!

This revision is now accepted and ready to land.Apr 15 2016, 3:15 PM
koriakin marked 2 inline comments as done.Apr 15 2016, 3:15 PM
This revision was automatically updated to reflect the committed changes.