This is an archive of the discontinued LLVM Phabricator instance.

clang-format: Allow include of clangFormat.h in managed context
ClosedPublic

Authored by mxbOctasic on Apr 13 2016, 9:56 AM.

Details

Summary

Including VirtualFileSystem.h in the clangFormat.h indirectly includes <atomic>.
This header is blocked when compiling with /clr.
I added a forward declaration of vfs::FileSystem in clangFormat.h and moved the include to clangFormat.cpp.

Diff Detail

Repository
rL LLVM

Event Timeline

mxbOctasic updated this revision to Diff 53579.Apr 13 2016, 9:56 AM
mxbOctasic retitled this revision from to clang-format: Allow include of clangFormat.h in managed context.
mxbOctasic updated this object.
mxbOctasic added a reviewer: djasper.
mxbOctasic added subscribers: cameron314, cfe-commits.
djasper accepted this revision.Apr 13 2016, 12:43 PM
djasper edited edge metadata.

Looks good.

include/clang/Format/Format.h
30 ↗(On Diff #53579)

nit: Remove this empty line.

This revision is now accepted and ready to land.Apr 13 2016, 12:43 PM
mxbOctasic updated this revision to Diff 53608.Apr 13 2016, 1:07 PM
mxbOctasic edited edge metadata.

Removed empty line.

This revision was automatically updated to reflect the committed changes.