This is an archive of the discontinued LLVM Phabricator instance.

Differential D18463

Sparc: silently ignore .proc assembler directive
ClosedPublic

Authored by dougk on Mar 24 2016, 3:09 PM.

Details

Reviewers
jyknight
Commits
rGd0c11cf7adb0: Sparc: silently ignore .proc assembler directive
rL264579: Sparc: silently ignore .proc assembler directive

Diff Detail

Event Timeline

dougk updated this revision to Diff 51609.Mar 24 2016, 3:09 PM
dougk retitled this revision from to Sparc: silently ignore .proc assembler directive.
dougk updated this object.
dougk added a reviewer: jyknight.
dougk added a subscriber: llvm-commits.
Herald added a subscriber: jyknight. · View Herald TranscriptMar 24 2016, 3:09 PM
jyknight accepted this revision.Mar 25 2016, 6:37 AM
jyknight edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2016, 6:37 AM
Closed by commit rL264579: Sparc: silently ignore .proc assembler directive (authored by dougk). · Explain WhyMar 28 2016, 7:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
Sparc/
AsmParser/
6 lines
test/
MC/
Sparc/
4 lines

Diff 51609

lib/Target/Sparc/AsmParser/SparcAsmParser.cpp

Context not available.
Parser.eatToEndOfStatement(); Parser.eatToEndOfStatement();
return false; return false;
} }
if (IDVal == ".proc") {
// For compatibility, ignore this directive.
// (It's supposed to be an "optimization" in the Sun assembler)
Parser.eatToEndOfStatement();
return false;
}
// Let the MC layer to handle other directives. // Let the MC layer to handle other directives.
return true; return true;
Context not available.

test/MC/Sparc/sparc-directives.s

! RUN: llvm-mc %s -arch=sparc -show-encoding | FileCheck %s --check-prefix=SPARC32 ! RUN: llvm-mc %s -arch=sparc -show-encoding | FileCheck %s --check-prefix=SPARC32
! RUN: llvm-mc %s -arch=sparcv9 -show-encoding | FileCheck %s --check-prefix=SPARC64 ! RUN: llvm-mc %s -arch=sparcv9 -show-encoding | FileCheck %s --check-prefix=SPARC64
! '.proc' is documented to do nothing in the binutils assembler.
! so it should do nothing for clang either, i.e. not be an error.
.proc 1
! SPARC32: .byte 24 ! SPARC32: .byte 24
! SPARC64: .byte 24 ! SPARC64: .byte 24
.byte 24 .byte 24