Page MenuHomePhabricator

[CUDA] Simplify SemaCUDA/function-overload.cu test.
ClosedPublic

Authored by jlebar on Mar 22 2016, 8:53 PM.

Details

Summary

Principally, don't hardcode the line numbers of various notes. This
lets us make changes to the test without recomputing linenos everywhere.

Instead, just tell -verify that we may get 0 or more notes pointing to
the relevant function definitions. Checking that we get exactly the
right note isn't so important (and anyway is checked elsewhere).

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 51382.Mar 22 2016, 8:53 PM
jlebar retitled this revision from to [CUDA] Simplify SemaCUDA/function-overload.cu test..
jlebar updated this object.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
tra accepted this revision.Mar 23 2016, 9:53 AM
tra edited edge metadata.

Small nit, LGTM otherwise.

test/SemaCUDA/function-overload.cu
66 ↗(On Diff #51382)

Minor nit: Notes that are common to all test runs should probably be 1+.

This revision is now accepted and ready to land.Mar 23 2016, 9:53 AM
jlebar marked an inline comment as done.Mar 23 2016, 3:14 PM

One comment is done, will be reflected when I submit. Thank you!

This revision was automatically updated to reflect the committed changes.