For clang-cl, implement additional compatibility arguments (/vm,/GF,/GF-,/Zm,/bigobj).

[kumquats.a.pair]

Summary

/vm* - There may be appropriate code in MicrosoftCXXABI.cpp to accommodate supporting this flag, but for now clang-cl compile arguments do not modify the behavior in MicrosoftCXXABI.cpp, so I set it up as unsupported.

/GF - Ignoring this flag as it appears to be the default behavior for C++ in Clang.

/GF- - For compatibility with some versions of cl.exe, aliasing to fwritable-strings. Empirical testing showed that /GF- was accepted, but did not function as described in the documentation for cl.exe 17.00.60610.1, but it should work for older versions of cl.exe.

/Zm - Ignoring this option because it is cl.exe specific and there's no reason to alarm the user that it has no consequences.

/bigobj - not supported that I know of.

[kumquats.a.pair]

This is a patch for clang-cl that implements additional compatibility arguments (/vm,/GF,/GF-,/Zm,/bigobj). Please review.

[rnk]

Looks good, do you need somebody to commit it?

include/clang/Driver/CLCompatOptions.td

178

Can you split this into the little /vm optoins, so we don't accept unknown /vmasdf args? I think we can accept and ignore /vmg, since that's our default behavior. We used to default to /vmb. I'd actually like to add support for going back to that mode, even though it doesn't conform.

[kumquats.a.pair]

Thanks for reviewing. I have modified the patch as requested in review.

The /vm* options are now enumerated individually.

/vmg - now silently ignored.
/vmb, /vmm, /vms, and /vmv - now marked as unsupported.

Please review again and submit if the revisions are acceptable.

Thanks!
David

[rnk]

Thanks, committed in r192141.

[Eugene.Zelenko]

Committed in rL192141.

include/clang/Driver/CLCompatOptions.td

   MetaVarName<"<macro[=value]>">, Alias<D>;
 def _SLASH_GR : CLFlag<"GR">, HelpText<"Enable RTTI">, Alias<frtti>;
 def _SLASH_GR_ : CLFlag<"GR-">, HelpText<"Disable RTTI">, Alias<fno_rtti>;
+def _SLASH_GF_ : CLFlag<"GF-">, HelpText<"Disable string pooling">,
+  Alias<fwritable_strings>;
 def _SLASH_help : CLFlag<"help">, Alias<help>,
   HelpText<"Display available options">;
 def _SLASH_I : CLJoinedOrSeparate<"I">,

 
 def _SLASH_analyze_ : CLIgnoredFlag<"analyze-">;
 def _SLASH_errorReport : CLIgnoredJoined<"errorReport">;
+def _SLASH_GF : CLIgnoredFlag<"GF">;
 def _SLASH_GS_ : CLIgnoredFlag<"GS-">;
 def _SLASH_nologo : CLIgnoredFlag<"nologo">;
 def _SLASH_Ob1 : CLIgnoredFlag<"Ob1">;
 def _SLASH_Ob2 : CLIgnoredFlag<"Ob2">;
 def _SLASH_RTC : CLIgnoredJoined<"RTC">;
+def _SLASH_w : CLIgnoredJoined<"w">;
 def _SLASH_Zc_forScope : CLIgnoredFlag<"Zc:forScope">;
 def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">;
-def _SLASH_w : CLIgnoredJoined<"w">;
+def _SLASH_Zm : CLIgnoredJoined<"Zm">;
 
 
 // Unsupported:
 
+def _SLASH_bigobj : CLFlag<"bigobj">;
 def _SLASH_EH : CLJoined<"EH">;
 def _SLASH_Fd : CLJoined<"Fd">;
 def _SLASH_fp : CLJoined<"fp">;

 def _SLASH_GZ : CLFlag<"GZ">;
 def _SLASH_MP : CLJoined<"MP">;
 def _SLASH_o : CLJoinedOrSeparate<"o">;
+def _SLASH_vm : CLJoined<"vm">;
 def _SLASH_Za : CLFlag<"Za">;
 def _SLASH_Zc : CLJoined<"Zc:">;
 def _SLASH_ZI : CLFlag<"ZI">;