Page MenuHomePhabricator

accept any build-id length between 4 and 20 bytes inclusive
ClosedPublic

Authored by emaste on Mar 11 2016, 12:22 PM.

Details

Summary

There's a proposed patch D18091 adding build-id support to lld that would produce a 64-bit ID. There's some concern as existing tools typically expect the build-id to be either 16 or 20 bytes.

Prior to this change lldb would reject such a build-id, but that doesn't make sense given that lldb will fall back to a 4-byte crc32, a poorer quality identifier. Now we accept the build-id if it is 4 bytes or more.

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 50464.Mar 11 2016, 12:22 PM
emaste retitled this revision from to accept any build-id length between 4 and 20 bytes inclusive .
emaste updated this object.
emaste added a reviewer: lldb-commits.
labath accepted this revision.Mar 14 2016, 2:56 AM
labath added a reviewer: labath.
labath added a subscriber: labath.

I think that's fine (you may want to add a note about the crc to the comment).

This revision is now accepted and ready to land.Mar 14 2016, 2:56 AM
This revision was automatically updated to reflect the committed changes.