This is an archive of the discontinued LLVM Phabricator instance.

Differential D17702

Fix unqualified type in AST_TYPE_MATCHER
AcceptedPublic

Authored by terrelln on Feb 28 2016, 9:17 PM.

Details

Reviewers
klimek
Summary

The AST matcher macro AST_TYPE_MATCHER used ::clang::Type unqualified.

Diff Detail

Event Timeline

terrelln updated this revision to Diff 49339.Feb 28 2016, 9:17 PM
terrelln retitled this revision from to Fix unqualified type in AST_TYPE_MATCHER.
terrelln updated this object.
Herald added a subscriber: klimek. · View Herald TranscriptFeb 28 2016, 9:17 PM
terrelln added a reviewer: klimek.Feb 29 2016, 3:00 PM
klimek accepted this revision.Mar 1 2016, 1:04 AM
klimek edited edge metadata.

LG

This revision is now accepted and ready to land.Mar 1 2016, 1:04 AM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.Sep 26 2016, 1:28 PM

Looks like patch was not committed.

Revision Contents

PathSize
include/
clang/
ASTMatchers/
2 lines

Diff 49339

include/clang/ASTMatchers/ASTMatchersMacros.h

Show First 20 Lines • Show All 357 Lines • ▼ Show 20 Lines bool internal::matcher_##DefineMatcher##OverloadId##Matcher< \
::clang::ast_matchers::internal::ASTMatchFinder *Finder, \ ::clang::ast_matchers::internal::ASTMatchFinder *Finder, \
::clang::ast_matchers::internal::BoundNodesTreeBuilder *Builder) \ ::clang::ast_matchers::internal::BoundNodesTreeBuilder *Builder) \
const const
/// \brief Creates a variadic matcher for both a specific \c Type as well as /// \brief Creates a variadic matcher for both a specific \c Type as well as
/// the corresponding \c TypeLoc. /// the corresponding \c TypeLoc.
#define AST_TYPE_MATCHER(NodeType, MatcherName) \ #define AST_TYPE_MATCHER(NodeType, MatcherName) \
const ::clang::ast_matchers::internal::VariadicDynCastAllOfMatcher< \ const ::clang::ast_matchers::internal::VariadicDynCastAllOfMatcher< \
Type, NodeType> MatcherName ::clang::Type, NodeType> MatcherName
// FIXME: add a matcher for TypeLoc derived classes using its custom casting // FIXME: add a matcher for TypeLoc derived classes using its custom casting
// API (no longer dyn_cast) if/when we need such matching // API (no longer dyn_cast) if/when we need such matching
/// \brief AST_TYPE_TRAVERSE_MATCHER(MatcherName, FunctionName) defines /// \brief AST_TYPE_TRAVERSE_MATCHER(MatcherName, FunctionName) defines
/// the matcher \c MatcherName that can be used to traverse from one \c Type /// the matcher \c MatcherName that can be used to traverse from one \c Type
/// to another. /// to another.
/// ///
/// For a specific \c SpecificType, the traversal is done using /// For a specific \c SpecificType, the traversal is done using
Show All 30 Lines