Page MenuHomePhabricator

Fix PythonDataObjectsTests for python 2
ClosedPublic

Authored by labath on Feb 23 2016, 8:38 AM.

Details

Summary

the python2 branch seems erroneous as it expected the object to be both a "String" and "Bytes".
Fix the expectation.

Diff Detail

Event Timeline

labath updated this revision to Diff 48820.Feb 23 2016, 8:38 AM
labath retitled this revision from to Fix PythonDataObjectsTests for python 2.
labath updated this object.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
zturner added inline comments.Feb 23 2016, 8:42 AM
unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp
212

Seems like this check is still valid?

zturner edited edge metadata.Feb 23 2016, 8:43 AM
labath added inline comments.Feb 23 2016, 8:47 AM
unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp
212

Not on python 2, I get "string" there. We can't have checks on line 212 and 216 both be true, so I assumed "string" is intended. Note that I have simply moved this check into the python-3 branch.

Any thoughts on this?

This is currently the only failing unit test on linux.

Sorry, was out for a few days and i missed this. Seems ok then

This revision was automatically updated to reflect the committed changes.