This is an archive of the discontinued LLVM Phabricator instance.

Shuffle an #undef to avoid a warning on FreeBSD
ClosedPublic

Authored by emaste on Feb 18 2016, 10:59 AM.

Download Raw Diff

Details

Reviewers

Commits

rG7d1eb1de744a: Shuffle an #undef to avoid a warning on FreeBSD
rLLDB263486: Shuffle an #undef to avoid a warning on FreeBSD
rL263486: Shuffle an #undef to avoid a warning on FreeBSD

Summary

On FreeBSD _LIBCPP_EXTERN_TEMPLATE is being defined from something included by lldb/lldb-private.h. Undefine it later to avoid the redefinition warning.

Diff Detail

Event Timeline

emaste updated this revision to Diff 48364.Feb 18 2016, 10:59 AM

emaste retitled this revision from to Shuffle an #undef to avoid a warning on FreeBSD.

emaste updated this object.

emaste added a subscriber: lldb-commits.

Herald added a subscriber: emaste. · View Herald TranscriptFeb 18 2016, 10:59 AM

emaste added a reviewer: chaoren.Mar 14 2016, 12:47 PM

Seems legit.

This revision is now accepted and ready to land.Mar 14 2016, 1:32 PM

Closed by commit rL263486: Shuffle an #undef to avoid a warning on FreeBSD (authored by emaste). · Explain WhyMar 14 2016, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

source/

Core/

CxaDemangle.cpp

3 lines

Diff 48364

source/Core/CxaDemangle.cpp

	Show All 14 Lines
	// - Changed argument to alignas() to a literal for MSVC			// - Changed argument to alignas() to a literal for MSVC
	// - Include <cstdio> for fprintf, stderr like entities.			// - Include <cstdio> for fprintf, stderr like entities.
	//----------------------------------------------------------------------			//----------------------------------------------------------------------

	#if defined(_MSC_VER)			#if defined(_MSC_VER)
	#include "lldb/Host/windows/win32.h" // snprintf			#include "lldb/Host/windows/win32.h" // snprintf
	#endif			#endif
	#include "llvm/Support/Compiler.h" // LLVM_{NOEXCEPT, CONSTEXPR, ALIGNAS}			#include "llvm/Support/Compiler.h" // LLVM_{NOEXCEPT, CONSTEXPR, ALIGNAS}
	#undef _LIBCPP_EXTERN_TEMPLATE // Avoid warning below

	#include "lldb/lldb-private.h"			#include "lldb/lldb-private.h"
				#undef _LIBCPP_EXTERN_TEMPLATE // Avoid warning below

	//===-------------------------- cxa_demangle.cpp --------------------------===//			//===-------------------------- cxa_demangle.cpp --------------------------===//
	//			//
	// The LLVM Compiler Infrastructure			// The LLVM Compiler Infrastructure
	//			//
	// This file is dual licensed under the MIT and the University of Illinois Open			// This file is dual licensed under the MIT and the University of Illinois Open
	// Source Licenses. See LICENSE.TXT for details.			// Source Licenses. See LICENSE.TXT for details.
	//			//
	▲ Show 20 Lines • Show All 4,982 Lines • Show Last 20 Lines