This is an archive of the discontinued LLVM Phabricator instance.

Fix some -Wundef warnings in include/llvm/ExecutionEngine/JITEventListener.h
ClosedPublic

Authored by tkelman on Feb 15 2016, 12:35 AM.

Download Raw Diff

Details

Reviewers

eliben
loladiro
lhames

Commits

rG71b5a81e7724: [JITEventListener] Fix some -Wundef warnings
rL263487: [JITEventListener] Fix some -Wundef warnings

Summary

This check was added in R152620, and has started causing downstream warnings in Julia:

In file included from /home/tkelman/Julia/julia-0.5/src/codegen.cpp:22:0:
/home/tkelman/Julia/julia-0.5/usr/include/llvm/ExecutionEngine/JITEventListener.h:84:5: warning: "LLVM_USE_INTEL_JITEVENTS" is not defined [-Wundef]
 #if LLVM_USE_INTEL_JITEVENTS
     ^
/home/tkelman/Julia/julia-0.5/usr/include/llvm/ExecutionEngine/JITEventListener.h:100:5: warning: "LLVM_USE_OPROFILE" is not defined [-Wundef]
 #if LLVM_USE_OPROFILE
     ^

Diff Detail

Event Timeline

tkelman updated this revision to Diff 47949.Feb 15 2016, 12:35 AM

tkelman retitled this revision from to Fix some -Wundef warnings in include/llvm/ExecutionEngine/JITEventListener.h.

tkelman updated this object.

tkelman added reviewers: eliben, lhames.

tkelman added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Mar 8 2016, 8:44 PM

Closed by commit rL263487: [JITEventListener] Fix some -Wundef warnings (authored by kfischer). · Explain WhyMar 14 2016, 1:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

include/

llvm/

ExecutionEngine/

JITEventListener.h

4 lines

Diff 47949

include/llvm/ExecutionEngine/JITEventListener.h

Show First 20 Lines • Show All 75 Lines • ▼ Show 20 Lines	public:

/// NotifyFreeingObject - Called just before the memory associated with		/// NotifyFreeingObject - Called just before the memory associated with
/// a previously emitted object is released.		/// a previously emitted object is released.
virtual void NotifyFreeingObject(const object::ObjectFile &Obj) {}		virtual void NotifyFreeingObject(const object::ObjectFile &Obj) {}

// Get a pointe to the GDB debugger registration listener.		// Get a pointe to the GDB debugger registration listener.
static JITEventListener *createGDBRegistrationListener();		static JITEventListener *createGDBRegistrationListener();

#if LLVM_USE_INTEL_JITEVENTS		#if defined(LLVM_USE_INTEL_JITEVENTS) && LLVM_USE_INTEL_JITEVENTS
// Construct an IntelJITEventListener		// Construct an IntelJITEventListener
static JITEventListener *createIntelJITEventListener();		static JITEventListener *createIntelJITEventListener();

// Construct an IntelJITEventListener with a test Intel JIT API implementation		// Construct an IntelJITEventListener with a test Intel JIT API implementation
static JITEventListener *createIntelJITEventListener(		static JITEventListener *createIntelJITEventListener(
IntelJITEventsWrapper* AlternativeImpl);		IntelJITEventsWrapper* AlternativeImpl);
#else		#else
static JITEventListener *createIntelJITEventListener() { return nullptr; }		static JITEventListener *createIntelJITEventListener() { return nullptr; }

static JITEventListener *createIntelJITEventListener(		static JITEventListener *createIntelJITEventListener(
IntelJITEventsWrapper* AlternativeImpl) {		IntelJITEventsWrapper* AlternativeImpl) {
return nullptr;		return nullptr;
}		}
#endif // USE_INTEL_JITEVENTS		#endif // USE_INTEL_JITEVENTS

#if LLVM_USE_OPROFILE		#if defined(LLVM_USE_OPROFILE) && LLVM_USE_OPROFILE
// Construct an OProfileJITEventListener		// Construct an OProfileJITEventListener
static JITEventListener *createOProfileJITEventListener();		static JITEventListener *createOProfileJITEventListener();

// Construct an OProfileJITEventListener with a test opagent implementation		// Construct an OProfileJITEventListener with a test opagent implementation
static JITEventListener *createOProfileJITEventListener(		static JITEventListener *createOProfileJITEventListener(
OProfileWrapper* AlternativeImpl);		OProfileWrapper* AlternativeImpl);
#else		#else

Show All 14 Lines