Page MenuHomePhabricator

AMDGPU/SI: When splitting SMRD instructions, add its users to VALU worklist
ClosedPublic

Authored by tstellarAMD on Feb 10 2016, 2:24 PM.

Details

Summary

When we split SMRD instructions into two MUBUFs we were adding the users
of the newly created MUBUFs to the VALU worklist. However, the only
users these instructions had was the REG_SEQUENCE that was inserted
by splitSMRD when the original SMRD instruction was split.

We need to make sure to add the users of the original SMRD to the VALU
worklist before it is split.

I have a test case, but it requires one other bug fix, so it will be
added in a later commt.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: When splitting SMRD instructions, add its users to VALU worklist.
tstellarAMD updated this object.
tstellarAMD added reviewers: arsenm, mareko.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Feb 10 2016, 2:32 PM
arsenm edited edge metadata.

LGTM.

I should finish my patch to create a global worklist to stop hitting this problem again

This revision is now accepted and ready to land.Feb 10 2016, 2:32 PM
This revision was automatically updated to reflect the committed changes.