Page MenuHomePhabricator

Separate invariant equivalence classes by type
ClosedPublic

Authored by jdoerfert on Feb 7 2016, 6:13 AM.

Details

Summary
This reverts r260023.

Diff Detail

Event Timeline

jdoerfert updated this revision to Diff 47126.Feb 7 2016, 6:13 AM
jdoerfert retitled this revision from to Separate invariant equivalence classes by type.
jdoerfert added reviewers: grosser, Meinersbur.
jdoerfert updated this object.
jdoerfert added a subscriber: Restricted Project.
grosser accepted this revision.Feb 7 2016, 6:30 AM
grosser edited edge metadata.

Hi Johannes,

thank you for fixing this. The changes look good to me, but it would be great if you could update the comments and possibly add 2-3 sentences in the commit message to make it easier for people to get the context of this change.

Best,
Tobias

include/polly/CodeGen/IslNodeBuilder.h
212

Maybe mention this in the comment?

include/polly/ScopInfo.h
857

The comment seems to still need an update.

This revision is now accepted and ready to land.Feb 7 2016, 6:30 AM
jdoerfert closed this revision.Feb 7 2016, 9:34 AM

Commited in r260045.