Page MenuHomePhabricator

[clang-tidy] Move implicit-cast-in-loop check to upstream.
ClosedPublic

Authored by hokein on Jan 29 2016, 5:29 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein updated this revision to Diff 46375.Jan 29 2016, 5:29 AM
hokein retitled this revision from to [clang-tidy] Move implicit-cast-in-loop check to upstream..
hokein updated this object.
hokein updated this revision to Diff 46377.Jan 29 2016, 5:43 AM

Add documents.

hokein set the repository for this revision to rL LLVM.
hokein added a subscriber: cfe-commits.
alexfh accepted this revision.Jan 29 2016, 7:04 AM
alexfh edited edge metadata.

Looks good with one nit. I'll fix and commit the patch.

Thank you!

clang-tidy/performance/ImplicitCastInLoopCheck.cpp
79 ↗(On Diff #46377)

No braces needed around single-line if bodies.

This revision is now accepted and ready to land.Jan 29 2016, 7:04 AM
alexfh added inline comments.Jan 29 2016, 7:06 AM
test/clang-tidy/performance_implicit_cast_in_loop.cpp
1 ↗(On Diff #46377)

Also, the name should use dashes, not underscores. I'll fix this as well.

This revision was automatically updated to reflect the committed changes.