This is an archive of the discontinued LLVM Phabricator instance.

Fix linking of lldb-server with BUILD_SHARED_LIBS
ClosedPublic

Authored by labath on Jan 28 2016, 3:18 AM.

Details

Summary

The BUILD_SHARED_LIBS branch of lldb-server link flags was hopelessly broken, at least since we
started restricting the symbols exported by liblldb. lldb-server depends on symbols from the
lldb_private namespace, so it cannot link to the public interface of liblldb. Instead I make it
link to the individual libraries constituting liblldb, just like it does in the
!BUILD_SHARED_LIBS case.

This does not make the BUILD_SHARED_LIBS build of lldb fully functional yet, due to the way
liblldb dependencies are managed, but it's a step in that direction.

Diff Detail

Event Timeline

labath updated this revision to Diff 46254.Jan 28 2016, 3:18 AM
labath retitled this revision from to Fix linking of lldb-server with BUILD_SHARED_LIBS.
labath updated this object.
labath added reviewers: zturner, tfiala.
labath added a subscriber: lldb-commits.
tfiala accepted this revision.Jan 28 2016, 10:49 AM
tfiala edited edge metadata.

Seems reasonable to me.

This revision is now accepted and ready to land.Jan 28 2016, 10:49 AM
This revision was automatically updated to reflect the committed changes.