Page MenuHomePhabricator

ELF: Report more than one undefined symbols if exist.
ClosedPublic

Authored by ruiu on Jan 27 2016, 11:16 AM.

Details

Reviewers
rafael
Summary

This patch depends on http://reviews.llvm.org/D16641.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 46160.Jan 27 2016, 11:16 AM
ruiu retitled this revision from to ELF: Report more than one undefined symbols if exist..
ruiu updated this object.
ruiu added a reviewer: rafael.
ruiu added a subscriber: llvm-commits.
emaste added a subscriber: emaste.Jan 27 2016, 12:05 PM

Happy to see this

rafael added inline comments.Jan 28 2016, 9:23 AM
ELF/Writer.cpp
425

I don't think this is related to this patch. This error is about a broken st_name, not about a user error.

899

Please move this just before addCommonSymbols.

ruiu added inline comments.Jan 28 2016, 10:53 AM
ELF/Writer.cpp
425

Done.

899

Done.

ruiu updated this revision to Diff 46295.Jan 28 2016, 10:53 AM
  • Address Rafael's comments.
rafael accepted this revision.Jan 28 2016, 2:44 PM
rafael edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 28 2016, 2:44 PM
ruiu closed this revision.Jan 28 2016, 3:01 PM