Page MenuHomePhabricator

[NFC] LoadInst: add two helper methods: getLoadedSize and getActualAlignment.
Needs ReviewPublic

Authored by eddyb on Jan 21 2016, 12:14 PM.

Details

Reviewers
dblaikie
mjacob
Summary

Depends on http://reviews.llvm.org/D16425, only commit after that.

Diff Detail

Event Timeline

eddyb updated this revision to Diff 45582.Jan 21 2016, 12:14 PM
eddyb retitled this revision from to [NFC] LoadInst: add two helper methods: getLoadedSize and getActualAlignment..
eddyb updated this object.
eddyb added reviewers: mjacob, dblaikie.
eddyb added a subscriber: llvm-commits.
mjacob edited edge metadata.Jan 21 2016, 5:53 PM

I think we should reverse the dependency and commit this before D16425.

include/llvm/IR/Instructions.h
296

I'm not sure I like this name. Unfortunately, I don't have a better idea. ;) Let me think about this over night, I won't accept this revision before tomorrow anyway.

298

I think it's more correct to say that this is the amount of bytes this instruction loads from memory. The loaded value doesn't really have a size.