Page MenuHomePhabricator

[LNT] Add hash of binary to ComparisonResult object.
ClosedPublic

Authored by kristof.beyls on Jan 20 2016, 6:16 AM.

Details

Summary

This doesn't add any user-visible functionality yet; but is a basis for
taking into account the hashes of binaries in analyses and views.

Diff Detail

Repository
rL LLVM

Event Timeline

kristof.beyls retitled this revision from to [LNT] Add hash of binary to ComparisonResult object..
kristof.beyls updated this object.
kristof.beyls added a reviewer: cmatthews.
kristof.beyls added a subscriber: llvm-commits.
cmatthews accepted this revision.Jan 27 2016, 4:24 PM
cmatthews edited edge metadata.

Looks good to me. On your fixme, that is a good idea. It is really a 1 liner to throw those in a set, and check the size. For now, just print an error in the log.

This revision is now accepted and ready to land.Jan 27 2016, 4:24 PM
This revision was automatically updated to reflect the committed changes.