Fixes to ensure TestLogging.py tests work with Python 3.5 as well as 2.7.

[amccarth]

Summary

Tested on Windows with Python 3.5.

[amccarth]

Used the more explicit assertion methods.

[zturner]

looks good

[amccarth]

This was committed a while back.

packages/Python/lldbsuite/test/logging/TestLogging.py

def command_log_tests (self, type):
 
         self.assertTrue (os.path.isfile (log_file))
 
         f = open (log_file)
         log_lines = f.readlines()
         f.close ()
         os.remove (log_file)
 
-        self.assertTrue(log_lines > 0, "Something was written to the log file.")
+        self.assertTrue(len(log_lines) > 0, "Something was written to the log file.")
 
     # Check that lldb truncates its log files
     @no_debug_info_test
     def test_log_truncate (self):
         if (os.path.exists (self.truncate_log_file)):
             os.remove (self.truncate_log_file)
 
         # put something in our log file
         with open(self.truncate_log_file, "w") as f:
             for i in range(1, 1000):
                 f.write("bacon\n")
 
         self.runCmd ("log enable -t -f '%s' lldb commands" % (self.truncate_log_file))
         self.runCmd ("help log")
         self.runCmd ("log disable lldb")
 
         self.assertTrue (os.path.isfile (self.truncate_log_file))
         with open(self.truncate_log_file, "r") as f:
             contents = f.read ()
 
         # check that it got removed
-        self.assertTrue(string.find(contents, "bacon") == -1)
+        self.assertTrue(contents.find("bacon") == -1)
 
     # Check that lldb can append to a log file
     @no_debug_info_test
     def test_log_append (self):
         if (os.path.exists (self.append_log_file)):
             os.remove (self.append_log_file)
 
         # put something in our log file
         with open(self.append_log_file, "w") as f:
             f.write("bacon\n")
 
         self.runCmd ("log enable -t -a -f '%s' lldb commands" % (self.append_log_file))
         self.runCmd ("help log")
         self.runCmd ("log disable lldb")
 
         self.assertTrue (os.path.isfile (self.append_log_file))
         with open(self.append_log_file, "r") as f:
             contents = f.read ()
 
         # check that it is still there
-        self.assertTrue(string.find(contents, "bacon") == 0)
+        self.assertTrue(contents.find("bacon") == 0)