This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Allow any number of PS inputs
ClosedPublic

Authored by mareko on Jan 9 2016, 3:26 PM.

Reviewers

• tstellarAMD
arsenm

Commits

Summary

With the ability to concatenate shader binaries, the limit of 15 no longer
applies.

mareko retitled this revision from to AMDGPU/SI: Allow any number of PS inputs.

mareko updated this object.

LGTM.

This revision is now accepted and ready to land.Jan 11 2016, 12:44 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Target/

AMDGPU/

4 lines

Show First 20 Lines • Show All 592 Lines • ▼ Show 20 Lines	SDValue SITargetLowering::LowerFormalArguments(
SmallVector<ISD::InputArg, 16> Splits;		SmallVector<ISD::InputArg, 16> Splits;
BitVector Skipped(Ins.size());		BitVector Skipped(Ins.size());

for (unsigned i = 0, e = Ins.size(), PSInputNum = 0; i != e; ++i) {		for (unsigned i = 0, e = Ins.size(), PSInputNum = 0; i != e; ++i) {
const ISD::InputArg &Arg = Ins[i];		const ISD::InputArg &Arg = Ins[i];

// First check if it's a PS input addr		// First check if it's a PS input addr
if (Info->getShaderType() == ShaderType::PIXEL && !Arg.Flags.isInReg() &&		if (Info->getShaderType() == ShaderType::PIXEL && !Arg.Flags.isInReg() &&
!Arg.Flags.isByVal()) {		!Arg.Flags.isByVal() && PSInputNum <= 15) {

assert((PSInputNum <= 15) && "Too many PS inputs!");

if (!Arg.Used && !Info->isPSInputAllocated(PSInputNum)) {		if (!Arg.Used && !Info->isPSInputAllocated(PSInputNum)) {
// We can safely skip PS inputs		// We can safely skip PS inputs
Skipped.set(i);		Skipped.set(i);
++PSInputNum;		++PSInputNum;
continue;		continue;
}		}

▲ Show 20 Lines • Show All 1,931 Lines • Show Last 20 Lines