This is an archive of the discontinued LLVM Phabricator instance.

clang: Make rewrite-includes-macros.cpp runnable on non-Win
ClosedPublic

Authored by thakis on Aug 18 2023, 6:57 AM.

Details

Summary

As far as I can tell, there's nothing Windows-specific about the
test and it passes fine on other platforms.

I found this test when running

rg clang_cl clang/test | rg '%s' | rg -v -- ' -- ' | rg -v not

after 547ee1c81fceaabcb to see if other tests were missing --
before %s in %clang_cl invocations. This was the only one.
Since it used to run only on Windows, it wasn't needed, but as far
as I can tell there's no reason to run it only on Windows.

Diff Detail

Event Timeline

thakis created this revision.Aug 18 2023, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 6:57 AM
thakis requested review of this revision.Aug 18 2023, 6:57 AM
aganea accepted this revision.Aug 18 2023, 7:38 AM

Sure. This was meant to catch an issue that only happened on Windows but it should work on all platforms.

LGTM.

This revision is now accepted and ready to land.Aug 18 2023, 7:38 AM
This revision was landed with ongoing or failed builds.Aug 19 2023, 7:47 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2023, 7:47 AM