Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D157787

[libc++][NFC] Refactor __enable_if return types to defaulted template parameters
ClosedPublic
Actions

Authored by philnik on Aug 12 2023, 9:34 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG9f3e3efd98a2: [libc++][NFC] Refactor __enable_if return types to defaulted template parameters
Summary

This brings most of the enable_ifs in libc++ to the same style. It also has the nice side-effect of reducing the size of names of these symbols, since the depedent return type is shorter.

Diff Detail

Event Timeline

philnik created this revision.Aug 12 2023, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 9:34 AM
philnik requested review of this revision.Aug 12 2023, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 9:34 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B252120: Diff 549624.Aug 12 2023, 3:14 PM
ldionne accepted this revision.Fri, Sep 1, 8:49 AM
ldionne added a subscriber: ldionne.

LGTM with green CI.

libcxx/include/cmath
647

Well spotted.

This revision is now accepted and ready to land.Fri, Sep 1, 8:49 AM
philnik updated this revision to Diff 555419.Fri, Sep 1, 9:45 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Fri, Sep 1, 5:52 PM
Closed by commit rG9f3e3efd98a2: [libc++][NFC] Refactor __enable_if return types to defaulted template parameters (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG9f3e3efd98a2: [libc++][NFC] Refactor __enable_if return types to defaulted template parameters.

Revision Contents
Changeset List

PathSize
libcxx/
include/
__algorithm/
12 lines
30 lines
__condition_variable/
10 lines
__functional/
8 lines
13 lines
22 lines
14 lines
4 lines
5 lines
16 lines
80 lines
12 lines
4 lines
4 lines

Diff 555541

View Options

libcxx/include/__algorithm/iterator_operations.h

Loading...
View Options

libcxx/include/__algorithm/sort.h

Loading...
View Options

libcxx/include/__condition_variable/condition_variable.h

Loading...
View Options

libcxx/include/__functional/bind.h

Loading...
View Options

libcxx/include/__hash_table

Loading...
View Options

libcxx/include/__split_buffer

Loading...
View Options

libcxx/include/__tree

Loading...
View Options

libcxx/include/array

Loading...
View Options

libcxx/include/cmath

Loading...
View Options

libcxx/include/forward_list

Loading...
View Options

libcxx/include/map

Loading...
View Options

libcxx/include/queue

Loading...
View Options

libcxx/include/stack

Loading...
View Options

libcxx/include/tuple

Loading...