Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[libc++][NFC] Refactor __enable_if return types to defaulted template parameters
ClosedPublic

Authored by philnik on Aug 12 2023, 9:34 AM.

Details

Summary

This brings most of the enable_ifs in libc++ to the same style. It also has the nice side-effect of reducing the size of names of these symbols, since the depedent return type is shorter.

Diff Detail

Event Timeline

philnik created this revision.Aug 12 2023, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 9:34 AM
philnik requested review of this revision.Aug 12 2023, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 9:34 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Fri, Sep 1, 8:49 AM
ldionne added a subscriber: ldionne.

LGTM with green CI.

libcxx/include/cmath
647

Well spotted.

This revision is now accepted and ready to land.Fri, Sep 1, 8:49 AM
philnik updated this revision to Diff 555419.Fri, Sep 1, 9:45 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Fri, Sep 1, 5:52 PM
This revision was automatically updated to reflect the committed changes.