This is an archive of the discontinued LLVM Phabricator instance.

Differential D157209

[compiler-rt] Fix typo in comment
ClosedPublic

Authored by Eymay on Aug 6 2023, 4:05 AM.

Details

Reviewers
fmayer
Commits
rG9724bf999b2b: [compiler-rt] Fix typo in comment

Diff Detail

Event Timeline

Eymay created this revision.Aug 6 2023, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 4:05 AM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
Eymay requested review of this revision.Aug 6 2023, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 4:05 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B250587: Diff 547547.Aug 6 2023, 4:22 AM
fmayer accepted this revision.Aug 7 2023, 11:02 AM
This revision is now accepted and ready to land.Aug 7 2023, 11:02 AM
Closed by commit rG9724bf999b2b: [compiler-rt] Fix typo in comment (authored by Eymay, committed by fmayer). · Explain WhyAug 22 2023, 11:13 AM
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG9724bf999b2b: [compiler-rt] Fix typo in comment.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 552444

compiler-rt/lib/sanitizer_common/sanitizer_file.h

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines
const char *GetPwd(); const char *GetPwd();
bool FileExists(const char *filename); bool FileExists(const char *filename);
bool DirExists(const char *path); bool DirExists(const char *path);
char *FindPathToBinary(const char *name); char *FindPathToBinary(const char *name);
bool IsPathSeparator(const char c); bool IsPathSeparator(const char c);
bool IsAbsolutePath(const char *path); bool IsAbsolutePath(const char *path);
// Returns true on success, false on failure. // Returns true on success, false on failure.
bool CreateDir(const char *pathname); bool CreateDir(const char *pathname);
// Starts a subprocess and returs its pid. // Starts a subprocess and returns its pid.
// If *_fd parameters are not kInvalidFd their corresponding input/output // If *_fd parameters are not kInvalidFd their corresponding input/output
// streams will be redirect to the file. The files will always be closed // streams will be redirect to the file. The files will always be closed
// in parent process even in case of an error. // in parent process even in case of an error.
// The child process will close all fds after STDERR_FILENO // The child process will close all fds after STDERR_FILENO
// before passing control to a program. // before passing control to a program.
pid_t StartSubprocess(const char *filename, const char *const argv[], pid_t StartSubprocess(const char *filename, const char *const argv[],
const char *const envp[], fd_t stdin_fd = kInvalidFd, const char *const envp[], fd_t stdin_fd = kInvalidFd,
fd_t stdout_fd = kInvalidFd, fd_t stderr_fd = kInvalidFd); fd_t stdout_fd = kInvalidFd, fd_t stderr_fd = kInvalidFd);
Show All 15 Lines