This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

Authored by jasonmolenda on Aug 4 2023, 5:20 PM.



ModuleList::GetSharedModule will call in to the DebugSymbols framework and may be able to find a file on the local system by Spotlight search, or by using the Platform's override of GetSharedModule, and may be faster than calling Symbols::DownloadObjectAndSymbolFile which calls out to an external program and is likely to do a network filesystem or download of the binary/symbol file.

A small perf improvement, NFC. This is very much jason code, not really looking for a review of this one.

Diff Detail

Event Timeline

jasonmolenda created this revision.Aug 4 2023, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 5:20 PM
jasonmolenda requested review of this revision.Aug 4 2023, 5:20 PM
This revision is now accepted and ready to land.Aug 5 2023, 11:55 AM

Rebase patch on current top of tree sources.

This revision was landed with ongoing or failed builds.Aug 8 2023, 5:31 PM
This revision was automatically updated to reflect the committed changes.