This patch changes gc.statepoint intrinsic's return type to token type instead of i32 type. Using token types could prevent LLVM to merge different gc.statepoint nodes into PHI nodes and cause further problems with gc relocations. The patch also changes the way on how gc.relocate and gc.result look for their corresponding gc.statepoint on unwind path. The current implementation uses the selector value extracted from a { i8*, i32 } landingpad as a hook to find the gc.statepoint, while the patch directly uses a token type landingpad (http://reviews.llvm.org/D15405) to find the gc.statepoint.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Looks good. (I didn't carefully read through all the test changes so I am assuming that they are all replacing i32 with token type).
Comment Actions
LGTM, too. I skimmed over the tests, and they seem to be fine. I can't comment on the invoke-related changes, though.
include/llvm/IR/Intrinsics.td | ||
---|---|---|
582–586 | These should either be updated or removed before committing this revision. I'd prefer the last option because these intrinsics were deprecated about 11 months ago. I'll prepare a revision for that. |
These should either be updated or removed before committing this revision. I'd prefer the last option because these intrinsics were deprecated about 11 months ago. I'll prepare a revision for that.