This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++] Update comments to reflect changes in ASan
ClosedPublic

Authored by AdvenamTacet on Jul 24 2023, 11:00 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG705fb08be1eb: [NFC][libc++] Update comments to reflect changes in ASan
Summary

ASan capabilities were extended, but some comments were not updated and describe old behavior. This commit updates outdated comments, which I found.
Mentioned changes are:

  • All allocators in containers (std::vector and std::deque; D146815 D136765) are supported, but it's possible to turn off annotations for a specific allocator (D145628).
  • Buffers don't have to be aligned (D132522).

Diff Detail

Event Timeline

AdvenamTacet created this revision.Jul 24 2023, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 11:00 AM
AdvenamTacet requested review of this revision.Jul 24 2023, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 11:00 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jul 24 2023, 11:20 AM
This revision is now accepted and ready to land.Jul 24 2023, 11:20 AM

Thx for fast review!

This revision was landed with ongoing or failed builds.Jul 24 2023, 11:33 AM
This revision was automatically updated to reflect the committed changes.