Page MenuHomePhabricator

[SLPVectorizer] Ensure dominated reduction values.
ClosedPublic

Authored by chatur01 on Dec 16 2015, 9:43 AM.

Details

Summary
When considering incoming values as part of a reduction phi, ensure the
incoming value is dominated by said phi.

Failing to ensure this property causes miscompiles.

Fixes PR25787.

Many thanks to Mattias Eriksson for reporting, reducing and analyzing the
problem for me.

Diff Detail

Event Timeline

chatur01 retitled this revision from to [SLPVectorizer] Ensure dominated reduction values..
chatur01 updated this object.
chatur01 added reviewers: nadav, materi.
chatur01 set the repository for this revision to rL LLVM.
chatur01 added a subscriber: llvm-commits.
nadav edited edge metadata.Dec 16 2015, 10:10 AM
nadav added a subscriber: nadav.

LGTM.

Thanks for fixing this Charlie!

This revision was automatically updated to reflect the committed changes.

Thanks for the review Nadav!