This is an archive of the discontinued LLVM Phabricator instance.

[libc] Default the GPU build to the default memory utilities
ClosedPublic

Authored by jhuber6 on Jul 18 2023, 8:49 AM.

Details

Summary

A previous patch made this cause an error on the GPU. We have not yet
dedicated time towards an optimial implementaiton there but we do not
want it to cause an error. We simply use the fallback routines.

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 18 2023, 8:49 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 18 2023, 8:49 AM
jhuber6 requested review of this revision.Jul 18 2023, 8:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 18 2023, 8:50 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

This patch is likely to fail as LIBC_SRC_STRING_MEMORY_UTILS_MEMSET et al. are not defined.

This patch is likely to fail as LIBC_SRC_STRING_MEMORY_UTILS_MEMSET et al. are not defined.

Had a bit of a mixuup, it's been reverted already. Thanks. Sorry the AMDGPU builder isn't in staging otherwise you'd probably catch this stuff.