This is an archive of the discontinued LLVM Phabricator instance.

Documenting behaviour of ResourceRef (HWInstructionDispatchedEvent)
ClosedPublic

Authored by rainerzufalldererste on Jul 14 2023, 4:21 PM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 4:21 PM
rainerzufalldererste requested review of this revision.Jul 14 2023, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 4:21 PM

I've worked on a project using MCA/llvm-mca and found the behaviour to be unintuitive and not explicitly documented anywhere afaik. It's used in llvm-mca/Views/ResourcePressureView.cpp:62 and reads the value via llvm::countr_zero there. I hope the comment is appreciated and the review doesn't cause any inconveniences.

andreadb accepted this revision.Jul 17 2023, 6:35 AM

LGTM Thanks!

This revision is now accepted and ready to land.Jul 17 2023, 6:35 AM

Sorry, first diff, would you mind comitting this for me?

This revision was automatically updated to reflect the committed changes.