This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PSTL] Implement std::rotate_copy
ClosedPublic

Authored by philnik on Jul 11 2023, 3:44 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG5d7f346bd398: [libc++][PSTL] Implement std::rotate_copy

Diff Detail

Event Timeline

philnik created this revision.Jul 11 2023, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 3:44 PM
philnik requested review of this revision.Jul 11 2023, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 3:44 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 546163.Aug 1 2023, 11:33 AM

Try to fix CI

LGTM but this needs to be rebased on top of exception safety + test changes for that

libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/pstl.rotate_copy.pass.cpp
2

Missing changes in robust_against_customization_point_foo

philnik updated this revision to Diff 550004.Aug 14 2023, 9:58 AM
philnik marked an inline comment as done.

Address comments

ldionne accepted this revision.Aug 16 2023, 9:06 AM
ldionne added inline comments.
libcxx/include/__algorithm/pstl_backend.h
174

Return type needs to be updated

libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/pstl.exception_handling.pass.cpp
27

boilerplate

libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/pstl.rotate_copy.pass.cpp
36

Could you add a test that validates that we didn't make any changes to the original range?

67
This revision is now accepted and ready to land.Aug 16 2023, 9:06 AM
philnik updated this revision to Diff 557638.Oct 7 2023, 2:27 AM
philnik marked 4 inline comments as done.

Address comments

philnik updated this revision to Diff 557838.Oct 23 2023, 3:37 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Oct 24 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.