This is an archive of the discontinued LLVM Phabricator instance.

C++20 Modules: update pr59999.cppm to reflect a reproducible state
Needs ReviewPublic

Authored by m4c0 on Jul 9 2023, 2:42 PM.

Details

Reviewers
ChuanqiXu
Summary

This is a extension for #59999 tests in order to make them reproduce the issue reported.

After local tests, I found out the definition in a "part unit" being instantiated in a deeper dependency tree is fundamental to the failure. So, in the case of this issue, splitting the code with its parts and the World module are important.

Also, I noticed more symbols are also important to reproduce the issue.

For extra context, this issue is Windows-only, and it was not failing all the time (my standalone minimal test took a couple of rebuilds until I had it crashing).

I'm trying to run this patch using LLVM sources on my machine, but unfortunately, I'm facing disk space issues (it's an old Windows machine).

Diff Detail

Event Timeline

m4c0 created this revision.Jul 9 2023, 2:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2023, 2:42 PM
m4c0 requested review of this revision.Jul 9 2023, 2:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2023, 2:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
m4c0 edited the summary of this revision. (Show Details)Jul 9 2023, 2:45 PM

Thanks for working on this.

The message from the CI bot shows there is something wrong with the updating.

I'm trying to run this patch using LLVM sources on my machine, but unfortunately, I'm facing disk space issues (it's an old Windows machine).

In this case, you can use apt.llvm.org to get the latest Clang builds. This is a workaround in your cases.