This is an archive of the discontinued LLVM Phabricator instance.

[include-cleaner] Ignore the layering-violation errors for the standalone tool
ClosedPublic

Authored by hokein on Jul 5 2023, 12:32 AM.

Details

Summary

If the source code is compilable-but-layzering-violation, we still want
the tool to be functional on it (rather than bailing out).

Diff Detail

Event Timeline

hokein created this revision.Jul 5 2023, 12:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2023, 12:32 AM
hokein requested review of this revision.Jul 5 2023, 12:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2023, 12:32 AM
kadircet accepted this revision.Jul 5 2023, 1:56 AM
kadircet added inline comments.
clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
99

maybe mention the general stance against diagnostics here?

We only want to perform include-cleaner analysis. So we disable diagnostics that won't affect our analysis to make the tool more robust against in-development code.

and then follow up with specific around disabling decluse

This revision is now accepted and ready to land.Jul 5 2023, 1:56 AM