This is an archive of the discontinued LLVM Phabricator instance.

Differential D154268

[lldb] Skip apple accelerator table test in DWARF 5 mode
ClosedPublic

Authored by fdeazeve on Jun 30 2023, 3:02 PM.

Details

Reviewers
JDevlieghere
jasonmolenda
Commits
rG379b59d1b0f3: [lldb] Skip apple accelerator table test in DWARF 5 mode
Summary

D68678 added a test that ensures an Apple accelerator lookup is done efficiently.
Since these tables are not used for DWARF 5, we should decorate the test
appropriately.

Diff Detail

Event Timeline

fdeazeve created this revision.Jun 30 2023, 3:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 3:02 PM
fdeazeve requested review of this revision.Jun 30 2023, 3:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 3:02 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
fdeazeve updated this revision to Diff 536450.Jun 30 2023, 3:03 PM

fix typo in commit message

Herald added a subscriber: JDevlieghere. · View Herald TranscriptJun 30 2023, 3:03 PM
fdeazeve edited the summary of this revision. (Show Details)Jun 30 2023, 3:03 PM
fdeazeve added a reviewer: JDevlieghere.
Harbormaster completed remote builds in B242572: Diff 536450.Jun 30 2023, 3:06 PM
jasonmolenda accepted this revision.Jun 30 2023, 3:11 PM
jasonmolenda added a subscriber: jasonmolenda.

LGTM.

This revision is now accepted and ready to land.Jun 30 2023, 3:11 PM
Closed by commit rG379b59d1b0f3: [lldb] Skip apple accelerator table test in DWARF 5 mode (authored by fdeazeve). · Explain WhyJul 3 2023, 5:36 AM
This revision was automatically updated to reflect the committed changes.
fdeazeve added a commit: rG379b59d1b0f3: [lldb] Skip apple accelerator table test in DWARF 5 mode.

Revision Contents

PathSize
lldb/
test/
API/
lang/
cpp/
accelerator-table/
1 line

Diff 536729

lldb/test/API/lang/cpp/accelerator-table/TestCPPAccelerator.py

import lldb import lldb
from lldbsuite.test.decorators import * from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import * from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil from lldbsuite.test import lldbutil
class CPPAcceleratorTableTestCase(TestBase): class CPPAcceleratorTableTestCase(TestBase):
@skipUnlessDarwin @skipUnlessDarwin
@skipIf(debug_info=no_match(["dwarf"])) @skipIf(debug_info=no_match(["dwarf"]))
@skipIf(dwarf_version=[">=", "5"])
def test(self): def test(self):
"""Test that type lookups fail early (performance)""" """Test that type lookups fail early (performance)"""
self.build() self.build()
logfile = self.getBuildArtifact("dwarf.log") logfile = self.getBuildArtifact("dwarf.log")
self.expect("log enable dwarf lookups -f" + logfile) self.expect("log enable dwarf lookups -f" + logfile)
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint( target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
Show All 15 Lines