This is an archive of the discontinued LLVM Phabricator instance.

[UBSan] Fix shared library linking in test for Darwin.
ClosedPublic

Authored by usama54321 on Jun 28 2023, 2:14 PM.

Details

Summary

Use ld_flags_rpath* substitutions.

Without rpath information, the test fails on some Darwin platforms since the binary fails to find the shared library.

rdar://110010041

Diff Detail

Event Timeline

usama54321 created this revision.Jun 28 2023, 2:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2023, 2:14 PM
Herald added a subscriber: Enna1. · View Herald Transcript
usama54321 requested review of this revision.Jun 28 2023, 2:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2023, 2:14 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
usama54321 edited the summary of this revision. (Show Details)Jun 28 2023, 2:20 PM
rsundahl accepted this revision.Jun 30 2023, 8:55 AM

Thank you for this one @usama54321. LGTM. I was able to look up the Radar but for others, I suggest a sentence in the description of the diff that explains why it was a problem for us.

This revision is now accepted and ready to land.Jun 30 2023, 8:55 AM
usama54321 edited the summary of this revision. (Show Details)Jun 30 2023, 12:49 PM
This revision was automatically updated to reflect the committed changes.