This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Fix building trunc*fhf2_test with GCC
ClosedPublic

Authored by arichardson on Jun 26 2023, 1:47 PM.

Details

Summary

GCC does not support __fp16, use the TYPE_FP16 macro instead.

Diff Detail

Event Timeline

arichardson created this revision.Jun 26 2023, 1:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 1:47 PM
Herald added a subscriber: Enna1. · View Herald Transcript
arichardson requested review of this revision.Jun 26 2023, 1:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 1:47 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
compnerd accepted this revision.Jun 30 2023, 8:10 PM

GCC does support __fp16 though requires passing -mfp16-format. However, I think that it should be fine to use TYPE_FP16. Please do clean up the commit message though.

This revision is now accepted and ready to land.Jun 30 2023, 8:10 PM
This revision was automatically updated to reflect the committed changes.