This is an archive of the discontinued LLVM Phabricator instance.

Differential D153410

[DFSAN] Add support for _tolower
ClosedPublic

Authored by tkuchta on Jun 21 2023, 5:00 AM.

Download Raw Diff

Details

Reviewers

Commits

rG9875273ad264: [DFSAN] Add support for _tolower

Summary

I noticed that in some cases _tolower shows as uninstrumented - I've added it as "functional" in the done_abilist.txt file

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

tkuchta created this revision.Jun 21 2023, 5:00 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 5:00 AM

Herald added a subscriber: Enna1. · View Herald Transcript

tkuchta requested review of this revision.Jun 21 2023, 5:00 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 5:00 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

tkuchta added a parent revision: D152196: [DFSAN] Add support for strncat.Jun 21 2023, 5:00 AM

Harbormaster completed remote builds in B240212: Diff 533216.Jun 21 2023, 5:00 AM

browneee accepted this revision.Jun 21 2023, 8:04 AM

This revision is now accepted and ready to land.Jun 21 2023, 8:04 AM

Please rebase and let it rerun the tests.

Rebase done

Harbormaster completed remote builds in B240537: Diff 533646.Jun 22 2023, 10:32 AM

browneee accepted this revision.Jun 22 2023, 1:45 PM

browneee added inline comments.

compiler-rt/lib/dfsan/done_abilist.txt
91	Note to self: this seems to be a macro on some platforms, but not a macro on others.

Closed by commit rG9875273ad264: [DFSAN] Add support for _tolower (authored by tkuchta, committed by browneee). · Explain WhyJun 22 2023, 1:49 PM

This revision was automatically updated to reflect the committed changes.

browneee added a commit: rG9875273ad264: [DFSAN] Add support for _tolower.

tkuchta added a child revision: D153775: [DFSAN] Add support for sscanf.Jun 26 2023, 8:06 AM

Revision Contents

Path

Size

compiler-rt/

lib/

dfsan/

done_abilist.txt

1 line

Diff 533772

compiler-rt/lib/dfsan/done_abilist.txt

	Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
	fun:isalpha=functional			fun:isalpha=functional
	fun:isdigit=functional			fun:isdigit=functional
	fun:isprint=functional			fun:isprint=functional
	fun:isxdigit=functional			fun:isxdigit=functional
	fun:isalnum=functional			fun:isalnum=functional
	fun:ispunct=functional			fun:ispunct=functional
	fun:isspace=functional			fun:isspace=functional
	fun:tolower=functional			fun:tolower=functional
				fun:_tolower=functional
				browneeeUnsubmitted Done Reply Inline Actions Note to self: this seems to be a macro on some platforms, but not a macro on others. browneee: Note to self: this seems to be a macro on some platforms, but not a macro on others.
	fun:toupper=functional			fun:toupper=functional

	# Functions that return a value that is data-dependent on the input.			# Functions that return a value that is data-dependent on the input.
	fun:__isinf=functional			fun:__isinf=functional
	fun:__isinff=functional			fun:__isinff=functional
	fun:__signbit=functional			fun:__signbit=functional
	fun:__signbitf=functional			fun:__signbitf=functional
	fun:__signbitl=functional			fun:__signbitl=functional
	▲ Show 20 Lines • Show All 377 Lines • Show Last 20 Lines