First small part of https://reviews.llvm.org/D151896
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Sorry, but would it be possible to to a patch per class instead, starting with stringbuf? That way I can keep track that all classes are done. The subtile differences in all overloads make it really annoying the review for correctness.
Would you like all the changes in stringbuf in one patch? That's quite a lot.
The remaining three classes are just simple wrappers over stringbuf.
I thought it would be easier to split into features.
Also, I expect that users don't typically use stringbuf directly, so having features exposed in *stringstream is what they care. That's how we proceeded with the already merged view().
Yes I would like that, I've already reviewed all code changes in stringbuf so that would be faster for me to review again.
Also, I expect that users don't typically use stringbuf directly, so having features exposed in *stringstream is what they care. That's how we proceeded with the already merged view().
I agree, that most users don't care about these "internals". Still we need them to implement the "externals". I think the externals are smaller and can be reviewed a lot faster. It's mainly that I have limited time to work on libc++ and large complex patches are quite hard to find time for.
Ok, I'll submit a patch implementing the whole paper in stringbuf. Since you asked for a separate test per overload, be prepared for two dozen tests. :)