This is an archive of the discontinued LLVM Phabricator instance.

Differential D153301

[libc++] Add missing [[maybe_unused]] attribute in format tests
ClosedPublic

Authored by ldionne on Jun 19 2023, 11:40 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGc20d81bd63b0: [libc++] Add missing [[maybe_unused]] attribute in format tests
Summary

Otherwise, Clang complains about format_ctx being unused in the tests
when exceptions are disabled in Freestanding mode. I don't know why it
doesn't complain not in freestanding mode.

Diff Detail

Event Timeline

ldionne created this revision.Jun 19 2023, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 11:40 AM
ldionne requested review of this revision.Jun 19 2023, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 11:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B239861: Diff 532724.Jun 19 2023, 10:03 PM
Mordante accepted this revision.Jun 20 2023, 8:06 AM
Mordante added a subscriber: Mordante.

LGTM!

This revision is now accepted and ready to land.Jun 20 2023, 8:06 AM
Closed by commit rGc20d81bd63b0: [libc++] Add missing [[maybe_unused]] attribute in format tests (authored by ldionne). · Explain WhyJun 20 2023, 8:25 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGc20d81bd63b0: [libc++] Add missing [[maybe_unused]] attribute in format tests.

Revision Contents

PathSize
libcxx/
test/
std/
utilities/
format/
format.range/
format.range.fmtdef/
5 lines
format.range.fmtmap/
5 lines
format.range.fmtset/
5 lines
format.range.formatter/
5 lines
format.tuple/
5 lines

Diff 532948

libcxx/test/std/utilities/format/format.range/format.range.fmtdef/format.pass.cpp

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
template <class CharT> template <class CharT>
void test_assure_parse_is_called() { void test_assure_parse_is_called() {
using String = std::basic_string<CharT>; using String = std::basic_string<CharT>;
using OutIt = std::back_insert_iterator<String>; using OutIt = std::back_insert_iterator<String>;
using FormatCtxT = std::basic_format_context<OutIt, CharT>; using FormatCtxT = std::basic_format_context<OutIt, CharT>;
std::array<parse_call_validator, 2> arg; std::array<parse_call_validator, 2> arg;
String result; String result;
OutIt out = std::back_inserter(result); OutIt out = std::back_inserter(result);
FormatCtxT format_ctx = test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg)); [[maybe_unused]] FormatCtxT format_ctx =
test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg));
{ // parse not called { // parse not called
[[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter; [[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter;
TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx)); TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx));
} }
test_assure_parse_is_called(SV("5")); test_assure_parse_is_called(SV("5"));
test_assure_parse_is_called(SV("n")); test_assure_parse_is_called(SV("n"));
Show All 23 Lines

libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.pass.cpp

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines
template <class CharT> template <class CharT>
void test_assure_parse_is_called() { void test_assure_parse_is_called() {
using String = std::basic_string<CharT>; using String = std::basic_string<CharT>;
using OutIt = std::back_insert_iterator<String>; using OutIt = std::back_insert_iterator<String>;
using FormatCtxT = std::basic_format_context<OutIt, CharT>; using FormatCtxT = std::basic_format_context<OutIt, CharT>;
std::map<parse_call_validator, parse_call_validator> arg{{parse_call_validator{}, parse_call_validator{}}}; std::map<parse_call_validator, parse_call_validator> arg{{parse_call_validator{}, parse_call_validator{}}};
String result; String result;
OutIt out = std::back_inserter(result); OutIt out = std::back_inserter(result);
FormatCtxT format_ctx = test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg)); [[maybe_unused]] FormatCtxT format_ctx =
test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg));
{ // parse not called { // parse not called
[[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter; [[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter;
TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx)); TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx));
} }
test_assure_parse_is_called(SV("5")); test_assure_parse_is_called(SV("5"));
test_assure_parse_is_called(SV("n")); test_assure_parse_is_called(SV("n"));
Show All 25 Lines

libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.pass.cpp

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines
template <class CharT> template <class CharT>
void test_assure_parse_is_called() { void test_assure_parse_is_called() {
using String = std::basic_string<CharT>; using String = std::basic_string<CharT>;
using OutIt = std::back_insert_iterator<String>; using OutIt = std::back_insert_iterator<String>;
using FormatCtxT = std::basic_format_context<OutIt, CharT>; using FormatCtxT = std::basic_format_context<OutIt, CharT>;
std::set<parse_call_validator> arg{parse_call_validator{}}; std::set<parse_call_validator> arg{parse_call_validator{}};
String result; String result;
OutIt out = std::back_inserter(result); OutIt out = std::back_inserter(result);
FormatCtxT format_ctx = test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg)); [[maybe_unused]] FormatCtxT format_ctx =
test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg));
{ // parse not called { // parse not called
[[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter; [[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter;
TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx)); TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx));
} }
test_assure_parse_is_called(SV("5")); test_assure_parse_is_called(SV("5"));
test_assure_parse_is_called(SV("n")); test_assure_parse_is_called(SV("n"));
Show All 22 Lines

libcxx/test/std/utilities/format/format.range/format.range.formatter/format.pass.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
template <class CharT> template <class CharT>
void test_assure_parse_is_called() { void test_assure_parse_is_called() {
using String = std::basic_string<CharT>; using String = std::basic_string<CharT>;
using OutIt = std::back_insert_iterator<String>; using OutIt = std::back_insert_iterator<String>;
using FormatCtxT = std::basic_format_context<OutIt, CharT>; using FormatCtxT = std::basic_format_context<OutIt, CharT>;
std::vector<parse_call_validator> arg{1}; std::vector<parse_call_validator> arg{1};
String result; String result;
OutIt out = std::back_inserter(result); OutIt out = std::back_inserter(result);
FormatCtxT format_ctx = test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg)); [[maybe_unused]] FormatCtxT format_ctx =
test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg));
{ // parse not called { // parse not called
[[maybe_unused]] const std::range_formatter<parse_call_validator, CharT> formatter; [[maybe_unused]] const std::range_formatter<parse_call_validator, CharT> formatter;
TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx)); TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx));
} }
// The range-format-spec has no range-underlying-spec // The range-format-spec has no range-underlying-spec
// This uses various variants, which have different code paths in libc++ // This uses various variants, which have different code paths in libc++
Show All 28 Lines

libcxx/test/std/utilities/format/format.tuple/format.pass.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
template <class CharT> template <class CharT>
void test_assure_parse_is_called() { void test_assure_parse_is_called() {
using String = std::basic_string<CharT>; using String = std::basic_string<CharT>;
using OutIt = std::back_insert_iterator<String>; using OutIt = std::back_insert_iterator<String>;
using FormatCtxT = std::basic_format_context<OutIt, CharT>; using FormatCtxT = std::basic_format_context<OutIt, CharT>;
std::pair<parse_call_validator, parse_call_validator> arg; std::pair<parse_call_validator, parse_call_validator> arg;
String result; String result;
OutIt out = std::back_inserter(result); OutIt out = std::back_inserter(result);
FormatCtxT format_ctx = test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg)); [[maybe_unused]] FormatCtxT format_ctx =
test_format_context_create<OutIt, CharT>(out, std::make_format_args<FormatCtxT>(arg));
{ // parse not called { // parse not called
[[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter; [[maybe_unused]] const std::formatter<decltype(arg), CharT> formatter;
TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx)); TEST_THROWS_TYPE(parse_call_validator::parse_function_not_called, formatter.format(arg, format_ctx));
} }
test_assure_parse_is_called(SV("5")); test_assure_parse_is_called(SV("5"));
test_assure_parse_is_called(SV("n")); test_assure_parse_is_called(SV("n"));
Show All 27 Lines