This is an archive of the discontinued LLVM Phabricator instance.

Differential D153068

Remove unnecessary condition and assignment.
AbandonedPublic

Authored by SlaterLatiao on Jun 15 2023, 1:06 PM.

Details

Reviewers
None

Diff Detail

Event Timeline

SlaterLatiao created this revision.Jun 15 2023, 1:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 1:06 PM
SlaterLatiao requested review of this revision.Jun 15 2023, 1:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 1:06 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
SlaterLatiao abandoned this revision.Jun 15 2023, 1:07 PM
Harbormaster completed remote builds in B239221: Diff 531883.Jun 15 2023, 1:07 PM

Revision Contents

PathSize
clang/
lib/
Frontend/
8 lines

Diff 531883

clang/lib/Frontend/DiagnosticRenderer.cpp

Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines
/// \param PLoc The presumed location of the diagnostic location. /// \param PLoc The presumed location of the diagnostic location.
/// \param Level The diagnostic level of the message this stack pertains to. /// \param Level The diagnostic level of the message this stack pertains to.
void DiagnosticRenderer::emitIncludeStack(FullSourceLoc Loc, PresumedLoc PLoc, void DiagnosticRenderer::emitIncludeStack(FullSourceLoc Loc, PresumedLoc PLoc,
DiagnosticsEngine::Level Level) { DiagnosticsEngine::Level Level) {
FullSourceLoc IncludeLoc = FullSourceLoc IncludeLoc =
PLoc.isInvalid() ? FullSourceLoc() PLoc.isInvalid() ? FullSourceLoc()
: FullSourceLoc(PLoc.getIncludeLoc(), Loc.getManager()); : FullSourceLoc(PLoc.getIncludeLoc(), Loc.getManager());
// Reset `LastIncludeLoc` on a new error so that the include stacks are // Skip redundant include stacks altogether on non-top-level.
// not skipped. if (Level != DiagnosticsEngine::Error && LastIncludeLoc == IncludeLoc)
if (Level == DiagnosticsEngine::Error)
LastIncludeLoc = SourceLocation();
// Skip redundant include stacks altogether.
if (LastIncludeLoc == IncludeLoc)
return; return;
LastIncludeLoc = IncludeLoc; LastIncludeLoc = IncludeLoc;
if (!DiagOpts->ShowNoteIncludeStack && Level == DiagnosticsEngine::Note) if (!DiagOpts->ShowNoteIncludeStack && Level == DiagnosticsEngine::Note)
return; return;
if (IncludeLoc.isValid()) if (IncludeLoc.isValid())
▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines