• Added test case for partial expansion.

• Make transforming expressions for member packs a separate function.
• Minor edits based on review comments.

• Minor fix on comment.
• Replace string '+' with Twine.

Remove changes in D156546 which doesn't belong to this patch.

Address review comments.

• Refactor instantiating members into 2 functions.

• Address review comments.

Fix code.

In D156546#4543697, @dblaikie wrote:

(just a side note about the title of this patch: I got "packed data members" confused and thought this was referring to struct packing __attribute__((packed)) - so perhaps something more like "data member packs" would be a more clear term here?)

Address comments.

• Added test case of duplicate types in template arguments.
• Added ending new line to test case file.
• Renamed "packed data members" -> "data member packs"

Revert last commit.

• Address review comments.

• Emit include stack on all top-level diagnostics.

Remove unnecessary condition and assignment in implementation.

• Added release note.

• Add newline to end of file.

Adding back the -triple flag

I shouldn't remove -triple=x86_64-none-none in the test case. The "padding struct 'S1' with 1 byte" warning can be different in different architectures. I'll add it back.

In D151162#4373027, @aaron.ballman wrote:

LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like us to use for patch attribution?

• Fix missing parenthesis.

• Test behavior of -Wpacked-non-pod in -Wall and update test case name.
• Update release note.

In D151162#4369584, @aaron.ballman wrote:

Please be sure to add a release note for the change, and it'd probably be good to have a test case that shows this triggers under -Wall (the modified test case explicitly names the diagnostic).

• Removed the -triple flag from warn-padded-packed testcase.

Test -Wpacked-non-pod not emitting warnings of "packed attribute is unnecessary".