This is an archive of the discontinued LLVM Phabricator instance.

[gn] Add Mac support to check-asan target
ClosedPublic

Authored by lgrey on Jun 9 2023, 3:38 PM.

Details

Summary

I semi don't know what I'm doing here, but this seems to do the trick

Diff Detail

Event Timeline

lgrey created this revision.Jun 9 2023, 3:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 3:38 PM
Herald added a subscriber: Enna1. · View Herald Transcript
lgrey requested review of this revision.Jun 9 2023, 3:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 3:38 PM
aeubanks accepted this revision.Jun 9 2023, 3:43 PM

lg with comment addressed, keep an eye on http://45.33.8.238/ after submitting

llvm/utils/gn/secondary/compiler-rt/test/asan/BUILD.gn
55

for simplicity we should just add everything from here unconditionally

This revision is now accepted and ready to land.Jun 9 2023, 3:43 PM
lgrey updated this revision to Diff 530495.Jun 12 2023, 6:54 AM

Unconditional tool/util deps

lgrey marked an inline comment as done.Jun 12 2023, 6:54 AM
This revision was landed with ongoing or failed builds.Jun 12 2023, 6:59 AM
This revision was automatically updated to reflect the committed changes.