This is an archive of the discontinued LLVM Phabricator instance.

Differential D152449

[lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.
ClosedPublic

Authored by oontvoo on Jun 8 2023, 8:24 AM.

Details

Reviewers
fdeazeve
Commits
rG83cb2123be48: [lldb][NFC]Update debug (eh-frame) tests to work with new dwarwin MC changes
Summary

Details: D144999 potentially changes the debug format. Setting this new -femit-compact-unwind-non-canonical flag will preserve the old behaviour.

Another option would be to update this test to "expect-pass" (rather than expect-fail)
WDYT?

Diff Detail

Event Timeline

oontvoo created this revision.Jun 8 2023, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2023, 8:24 AM
oontvoo requested review of this revision.Jun 8 2023, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2023, 8:24 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
oontvoo mentioned this in D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..Jun 8 2023, 8:24 AM
oontvoo edited the summary of this revision. (Show Details)
Herald added a subscriber: JDevlieghere. · View Herald TranscriptJun 8 2023, 8:25 AM
Harbormaster completed remote builds in B237502: Diff 529604.Jun 8 2023, 8:27 AM
fdeazeve added a comment.Jun 8 2023, 9:52 AM

Thanks for looking into this! I think we should just remove the XFAIL instead, for the reasons you mentioned in the other patch!

oontvoo updated this revision to Diff 529653.Jun 8 2023, 9:57 AM

Removed XFAIL: system-darwin from test

oontvoo updated this revision to Diff 529654.Jun 8 2023, 9:58 AM

updated commit msg

fdeazeve accepted this revision.Jun 8 2023, 9:59 AM

LGTM!

This revision is now accepted and ready to land.Jun 8 2023, 9:59 AM
Harbormaster completed remote builds in B237538: Diff 529654.Jun 8 2023, 10:02 AM
Closed by commit rG83cb2123be48: [lldb][NFC]Update debug (eh-frame) tests to work with new dwarwin MC changes (authored by oontvoo). · Explain WhyJun 8 2023, 10:11 AM
This revision was automatically updated to reflect the committed changes.
oontvoo added a commit: rG83cb2123be48: [lldb][NFC]Update debug (eh-frame) tests to work with new dwarwin MC changes.

Revision Contents

PathSize
lldb/
test/
Shell/
Unwind/
1 line

Diff 529656

lldb/test/Shell/Unwind/prefer-debug-over-eh-frame.test

# Test that we prefer debug_frame over eh_frame unwind plans. They usually # Test that we prefer debug_frame over eh_frame unwind plans. They usually
# contain the same information, and we rarely have both kinds of entries for a # contain the same information, and we rarely have both kinds of entries for a
# single function. However, in theory the debug_frame plan can be more complete, # single function. However, in theory the debug_frame plan can be more complete,
# whereas eh_frame is only required to be correct at places where exceptions can # whereas eh_frame is only required to be correct at places where exceptions can
# be thrown. # be thrown.
# UNSUPPORTED: system-windows # UNSUPPORTED: system-windows
# XFAIL: system-darwin
# REQUIRES: target-x86_64, native # REQUIRES: target-x86_64, native
# RUN: %clang_host -g %p/Inputs/call-asm.c %p/Inputs/prefer-debug-over-eh-frame.s -o %t # RUN: %clang_host -g %p/Inputs/call-asm.c %p/Inputs/prefer-debug-over-eh-frame.s -o %t
# RUN: %lldb %t -s %s -o exit | FileCheck %s # RUN: %lldb %t -s %s -o exit | FileCheck %s
breakpoint set -n bar breakpoint set -n bar
# CHECK: Breakpoint 1: where = {{.*}}`bar # CHECK: Breakpoint 1: where = {{.*}}`bar
process launch process launch
# CHECK: stop reason = breakpoint 1.1 # CHECK: stop reason = breakpoint 1.1
target modules show-unwind -n foo target modules show-unwind -n foo
# CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'DWARF CFI plus augmentation from assembly parsing' # CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'DWARF CFI plus augmentation from assembly parsing'
# CHECK: Synchronous (restricted to call-sites) UnwindPlan is 'DWARF CFI' # CHECK: Synchronous (restricted to call-sites) UnwindPlan is 'DWARF CFI'
# CHECK: eh_frame UnwindPlan: # CHECK: eh_frame UnwindPlan:
# CHECK: debug_frame UnwindPlan: # CHECK: debug_frame UnwindPlan: