This is an archive of the discontinued LLVM Phabricator instance.

[NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()
ClosedPublic

Authored by Manna on May 30 2023, 7:26 PM.

Details

Summary

This patch uses castAs instead of getAs which will assert if the type doesn't match in SetValueDataBasedOnQualType(clang::​Value &, unsigned long long).

Diff Detail

Event Timeline

Manna created this revision.May 30 2023, 7:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 7:26 PM
Manna requested review of this revision.May 30 2023, 7:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 7:26 PM
Manna abandoned this revision.EditedMay 30 2023, 8:15 PM

I have updated PR.

Manna reclaimed this revision.May 31 2023, 5:21 AM
erichkeane accepted this revision.May 31 2023, 6:41 AM
This revision is now accepted and ready to land.May 31 2023, 6:41 AM
Manna added a comment.May 31 2023, 9:44 AM

Thank you @erichkeane for reviews!