This is an archive of the discontinued LLVM Phabricator instance.

[hwasan] RunMallocHooks with orig_size
ClosedPublic

Authored by Northbadge on May 26 2023, 12:24 PM.

Details

Summary

This matches behaviour of asan. sanitizer_common/TestCases/malloc_hook.cpp
should've caught this- but hwasan was on XFAIL.

Diff Detail

Event Timeline

Northbadge created this revision.May 26 2023, 12:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 12:24 PM
Herald added a subscriber: Enna1. · View Herald Transcript
Northbadge published this revision for review.May 26 2023, 12:49 PM

I'm not sure whether to leave the XFAIL in- hwasan is unsupported on buildbots and my system.

Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 12:49 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.May 30 2023, 6:19 PM
This revision is now accepted and ready to land.May 30 2023, 6:19 PM

Could you add check into corresponding sanitizer_common tests to make sure this case is covered?

Could you add check into corresponding sanitizer_common tests to make sure this case is covered?

not needed if this is XFAIL already
However make sure to run check-sanitizer, I assume you will have to remove XFAIL in this patch

Removed XFAIL from tests. Didn't build with lld previously so hwasan tests were unsupported

Northbadge edited the summary of this revision. (Show Details)May 31 2023, 10:58 AM
This revision was landed with ongoing or failed builds.May 31 2023, 11:20 AM
This revision was automatically updated to reflect the committed changes.