This is an archive of the discontinued LLVM Phabricator instance.

Differential D151213

[libc][AMDGPU] Disable the AMDGPU backend's ctor/dtor lowering for libc
ClosedPublic

Authored by jhuber6 on May 23 2023, 7:20 AM.

Details

Reviewers
None
Commits
rGad00a3db4dde: [libc][AMDGPU] Disable the AMDGPU backend's ctor/dtor lowering for libc
Summary

The AMDGPU backend has a built-in pass to lower constructors. We do this
manually in the start.cpp implementation so we can disable this to
keep the binaries smaller.

Diff Detail

Event Timeline

jhuber6 created this revision.May 23 2023, 7:20 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 23 2023, 7:20 AM
Herald added subscribers: libc-commits, ecnelises, kerbowa and 6 others. · View Herald Transcript
jhuber6 requested review of this revision.May 23 2023, 7:20 AM
Herald added a subscriber: wdng. · View Herald TranscriptMay 23 2023, 7:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2023, 7:20 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGad00a3db4dde: [libc][AMDGPU] Disable the AMDGPU backend's ctor/dtor lowering for libc (authored by jhuber6). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rGad00a3db4dde: [libc][AMDGPU] Disable the AMDGPU backend's ctor/dtor lowering for libc.
Harbormaster completed remote builds in B233863: Diff 524701.May 23 2023, 7:52 AM

Revision Contents

PathSize
libc/
startup/
gpu/
amdgpu/
1 line

Diff 524703

libc/startup/gpu/amdgpu/CMakeLists.txt

Show All 19 Lines
# Ensure that clang uses the correct linker for this object type. # Ensure that clang uses the correct linker for this object type.
target_link_libraries( target_link_libraries(
${fq_name} ${fq_name}
PUBLIC PUBLIC
"-mcpu=${LIBC_GPU_TARGET_ARCHITECTURE}" "-mcpu=${LIBC_GPU_TARGET_ARCHITECTURE}"
"--target=${LIBC_GPU_TARGET_TRIPLE}" "--target=${LIBC_GPU_TARGET_TRIPLE}"
"-flto" "-flto"
"-Wl,-mllvm,-amdgpu-lower-global-ctor-dtor=0"
) )