Page MenuHomePhabricator

Correction in TestFrames.py test for arm targets in thumb mode
ClosedPublic

Authored by omjavaid on Nov 29 2015, 5:08 PM.

Details

Summary

This patch adds required correction in TestFrames.py for arm targets in thumb mode.

On arm hardware thumb mode is identified by setting the least significant bit. In such case when we read PC we ll end up getting an unaligned address which has last bit set and will cause a mismatch between address read from dwarf frame information. I have corrected this by adding an appropriate check in TestFrames.py.

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 41359.Nov 29 2015, 5:08 PM
omjavaid retitled this revision from to Correction in TestFrames.py test for arm targets in thumb mode.
omjavaid updated this object.
omjavaid added a reviewer: tberghammer.
omjavaid added a subscriber: lldb-commits.
tberghammer accepted this revision.Nov 30 2015, 3:09 AM
tberghammer edited edge metadata.

LGTM

Note: We will have to enable the same functionality for some variant of mips also but I don't know the details so we should leave it for the mips guys.

This revision is now accepted and ready to land.Nov 30 2015, 3:09 AM
This revision was automatically updated to reflect the committed changes.