This is an archive of the discontinued LLVM Phabricator instance.

sanitizer_common: remove noisy warning about symbolizer not found.
ClosedPublic

Authored by krasin on Nov 25 2015, 1:54 PM.

Details

Summary

In r251553, I added a warning that proved to be super noisy,
especially in case of MSan. Removing it for now, and I will
probably add some additional diagnostics for symbolizer, when
I better understand how to make it properly.

Diff Detail

Event Timeline

krasin updated this revision to Diff 41183.Nov 25 2015, 1:54 PM
krasin retitled this revision from to sanitizer_common: remove noisy warning about symbolizer not found..
krasin updated this object.
krasin added a reviewer: eugenis.
eugenis added inline comments.Nov 25 2015, 1:56 PM
lib/sanitizer_common/sanitizer_symbolizer.h
147

this is not present in HEAD
please rebase the change

147

no wait, you are adding a line.
but why?

krasin updated this revision to Diff 41186.Nov 25 2015, 2:00 PM

remove accidental change

lib/sanitizer_common/sanitizer_symbolizer.h
147

it's a leftover from my attempt to only print the warning at the first time it tries to symbolize.
Removed.

eugenis accepted this revision.Nov 25 2015, 2:02 PM
eugenis edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 2:02 PM
krasin closed this revision.Nov 25 2015, 2:03 PM