This is an archive of the discontinued LLVM Phabricator instance.

Differential D149887

[libc] Remove support for atomic test due to failing on sm_60
ClosedPublic

Authored by jhuber6 on May 4 2023, 12:13 PM.

Details

Reviewers
None
Commits
rG9d0258e3634c: [libc] Remove support for atomic test due to failing on sm_60
Summary

This test fails on sm_60 because of the atomics codegen. We test atomics
indirectly with the rpc so we still have coverage.

Diff Detail

Event Timeline

jhuber6 created this revision.May 4 2023, 12:13 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 4 2023, 12:13 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
jhuber6 requested review of this revision.May 4 2023, 12:13 PM
Harbormaster completed remote builds in B230054: Diff 519595.May 4 2023, 12:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2023, 12:33 PM
Closed by commit rG9d0258e3634c: [libc] Remove support for atomic test due to failing on sm_60 (authored by jhuber6). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rG9d0258e3634c: [libc] Remove support for atomic test due to failing on sm_60.

Revision Contents

PathSize
libc/
test/
src/
__support/
CPP/
22 lines

Diff 519606

libc/test/src/__support/CPP/CMakeLists.txt

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Linesadd_libc_test(
SUITE SUITE
libc-cpp-utils-tests libc-cpp-utils-tests
SRCS SRCS
integer_sequence_test.cpp integer_sequence_test.cpp
DEPENDS DEPENDS
libc.src.__support.CPP.utility libc.src.__support.CPP.utility
) )
# This test fails with invalid address space operations on sm_60
if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
add_libc_test( add_libc_test(
atomic_test atomic_test
SUITE SUITE
libc-cpp-utils-tests libc-cpp-utils-tests
SRCS SRCS
atomic_test.cpp atomic_test.cpp
DEPENDS DEPENDS
libc.src.__support.CPP.atomic libc.src.__support.CPP.atomic
) )
endif()
# This test fails with a segmentation fault on NVPTX. # This test fails with a segmentation fault on NVPTX.
if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX) if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
add_libc_test( add_libc_test(
stringstream_test stringstream_test
SUITE SUITE
libc-cpp-utils-tests libc-cpp-utils-tests
SRCS SRCS
Show All 39 Lines